Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SlayerAnsh
left a comment
There was a problem hiding this comment.
Having 1 query that returns chain and associated channels (both ics20 and direct) would be better. In this approach client won't have sufficient info to map channels to chains
| QueryMsg::ListAllChannels { start_after, limit } => encode_binary( | ||
| &query::list_all_channels(deps, start_after.as_deref(), limit)?, | ||
| ), | ||
| QueryMsg::ListChainsWithChannels { start_after, limit } => encode_binary( |
There was a problem hiding this comment.
This looks good, we need another query that takes chain are argument and returns its channel details (both ics20 and direct). If its not present then it will error with Chain Not Found
There was a problem hiding this comment.
This is already covered by the ChannelInfo query, i'll adjust it to return an error if it's not found instead of a None value
Motivation
Users couldn't query all chains nor all channels
Implementation
Testing
None
Version Changes
kernel:1.2.5-b.3->1.2.5-b.4Checklist