Fix #118: Cannot find module '${HOME}/host.js'#119
Merged
andy-portmen merged 1 commit intoandy-portmen:masterfrom Jul 22, 2024
Merged
Fix #118: Cannot find module '${HOME}/host.js'#119andy-portmen merged 1 commit intoandy-portmen:masterfrom
andy-portmen merged 1 commit intoandy-portmen:masterfrom
Conversation
justfortherec
changed the title
It appears that Firefox starts the native client from `$HOME` as the working directory. That leads to the script resolving the relative path host.js as `$HOME/host.js`. This fix prefixes the `host.js` filename with the directory of the run.sh file. Now it works regardless of the working directory and regardless of the directory in which `run.sh` and the JavaScript files are located (as long as they are in the same location). Fix: andy-portmen#118
justfortherec
force-pushed
the
fix-118-cannot-find-module
branch
from
43da19b to
c43a570
Compare
justfortherec
changed the title
|
I do have same problem - this PR fixes it - please merge. |
|
I couldn't run the extension on ubuntu 24.04 LTS this fixed it. Please merge and release this. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that Firefox starts the native client from
$HOMEas the working directory. That leads to the script resolving the relative path host.js as$HOME/host.js.This fix prefixes the
host.jsfilename with the directory of the run.sh file. Now it works regardless of the working directory and regardless of the directory in whichrun.shand the JavaScript files are located (as long as they are in the same location).Fix: #118