Skip to content

Fix alt-screen scrollback capture edge cases#201

Merged
andyrewlee merged 2 commits intomainfrom
broken-scroll
Mar 17, 2026
Merged

Fix alt-screen scrollback capture edge cases#201
andyrewlee merged 2 commits intomainfrom
broken-scroll

Conversation

@andyrewlee
Copy link
Owner

@andyrewlee andyrewlee commented Mar 17, 2026

Summary

Describe the change and intended behavior.

Quality Checklist

  • Ran make devcheck locally.
  • Ran make lint-strict-new locally for changed code.
  • If UI/rendering changed, ran make harness-presets.
  • If tmux/e2e changed, ran go test ./internal/tmux ./internal/e2e.

Open with Devin

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy removed rows into a new slice before truncating Scrollback so
the returned slice doesn't alias the backing array — a subsequent
append could silently overwrite it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@andyrewlee andyrewlee merged commit 21c7f87 into main Mar 17, 2026
3 checks passed
@andyrewlee andyrewlee deleted the broken-scroll branch March 17, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant