Fix vterm alt-screen capture and scroll edge cases#202
Merged
andyrewlee merged 5 commits intomainfrom Mar 18, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d01cc-daff-756a-8c08-83207b167180 Co-authored-by: Amp <amp@ampcode.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…Offset Amp-Thread-ID: https://ampcode.com/threads/T-019d01cc-daff-756a-8c08-83207b167180 Co-authored-by: Amp <amp@ampcode.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dropTrackedAltScreenCapture zeroed captureLen and tracked but not endOffset. When dedupScrollUpTrailing found no overlap, the stale endOffset was inherited by the next capture, causing captureStart miscalculation and scrollback corruption on subsequent cycles. Reset endOffset to 0 after dedup in the drop path. Also document the known trailing-growth limitation in dedupScrollUpTrailing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-019d01cc-daff-756a-8c08-83207b167180
Summary
Describe the change and intended behavior.
Quality Checklist
make devchecklocally.make lint-strict-newlocally for changed code.make harness-presets.go test ./internal/tmux ./internal/e2e.