Skip to content
Grant Bourque edited this page Jun 12, 2018 · 6 revisions

Purpose

The Anedot fork was created in Jan 2017 mainly to work on the Litle/Vantiv integration support.

Local repo setup

  • git clone [email protected]:anedot/active_merchant.git
    • our fork
    • Note: removed all branches but master (then git remote prune origin)
  • git remote add upstream [email protected]:activemerchant/active_merchant.git
    • provide remote to pull in changes in upstream
  • git fetch --all
    • fetch all branches from all remotes

Testing

  • bundle exec rake test:units TEST=test/unit/gateways/vantiv_test.rb for unit tests.
  • Make sure to fill out test/fixtures.yml with some good credentials for the remote certification tests.
  • Make sure to VPN as needed to have a whitelisted IP for the remote certification tests.
  • bundle exec rake test:remote TEST=test/remote/gateways/remote_vantiv_certification_test.rb SKIP_NON_REPEATABLE_TESTS=true for the idempotent remote certification tests. The test suite may not pass multiple times without SKIP_NON_REPEATABLE_TESTS=true because some of the tests change the state of your Vantiv environment forever.

Set up branches for upstream PRs

We are integrating these in our repo - you may not need to do this just to work on the existing integration

  • git fetch upstream pull/PRNUMBER/head:upstream-pr--PRNUMBER--PRDESCRIPTION
    • fetches a PR branch from the upstream repo and creates a local branch for integration work

The following PR branches were created and pushed to our fork

  • git fetch upstream pull/2006/head:upstream-pr--2006--litle-purchase-with-token-and-billing-address
  • git fetch upstream pull/2116/head:upstream-pr--2116--litle-refund-with-token-purchase-exp-date
  • git fetch upstream pull/1925/head:upstream-pr--1925--litle-add-paypage-registration-id-support

"upstream-pr--NUMBER--desc" branches are to track PR branches as they appear on upstream in case they change on us.

PR branches were rebased on master to fix basic issues and resolve merge conflicts.

Merged in order 1925, 2006, 2116

Branches pushed to origin:

  • remotes/origin/upstream-pr--1925--rebased
  • remotes/origin/upstream-pr--2006--rebased
  • remotes/origin/upstream-pr--2116--rebased

Branch containing all rebased PR branches.

  • remotes/origin/upstream--litle-prs--rebased

WIP branch to contain Anedot work to get gateway functional:

  • remotes/origin/litle-gateway

Commits should be VERY explanatory and potentially reflect if they would be suited as updates to existing PRs.


Notes:

https://github.com/activemerchant/active_merchant/pull/2116 seems to add the expiration date referenced in https://github.com/activemerchant/active_merchant/issues/2273 (which was merged into the chargify fork - https://github.com/chargify/active_merchant/pull/41/files with a slightly different implementation - I left a note on the chargify PR for them)

https://github.com/activemerchant/active_merchant/pull/1925 was closed in a bit auto-close-fest on upstream. I've left a comment to see if they'll re-open as it seems to do what we want, or at least provides some implementation guidance.