Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement TLS for Redis #814

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Nico-dl05
Copy link
Contributor

Motivation

This PR aims to implement the TLS for Redis and improving the handling of dependencies between the submitter and redis.

Description

  • TLS Implementation:
    • Added support for secure connections to Redis using TLS.
    • Configured Redis to use certificates for authentication (ca.pem, redis.crt, redis.key).
  • Generic Callback for TLS:
    • Created a generic mechanism to handle TLS configuration and callbacks during deployment.
  • Wait for Redis:
    • Implemented a conditional wait_for_redis mechanism to ensure that Redis is fully initialized before the Submitter starts.
    • Dynamically adjusts dependencies and paths based on the environment (local or CI).
  • Mounting Redis Certificates:
    • Added conditional mounts for Redis certificates, ensuring secure communication between the Submitter and Redis.

Testing

  • Verified container initialization and deployement in local environnement
  • Ran HtcMock tests to ensure proper communication between Redis and the Submitter

Impact

  • TLS implemented:
  • Behavioral Changes: Ensures Submitter does not start until Redis is ready.

Additional Information

This is a work in progress, and further tests / fixes and optimizations are ongoing.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@Nico-dl05 Nico-dl05 requested a review from aneojgurhem January 13, 2025 10:22
@Nico-dl05 Nico-dl05 force-pushed the ndl/generic-callback-tls branch 8 times, most recently from a80785e to b0087fd Compare January 14, 2025 09:19
@Nico-dl05 Nico-dl05 force-pushed the ndl/generic-callback-tls branch 12 times, most recently from 5f5ab4e to 8827549 Compare January 17, 2025 16:01
@Nico-dl05 Nico-dl05 force-pushed the ndl/generic-callback-tls branch from 8827549 to aef6893 Compare January 17, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants