Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose max_memory_samples parameter for redis/elasticache #1227

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

alouvion-aneo
Copy link
Contributor

@alouvion-aneo alouvion-aneo commented Oct 12, 2023

linked to infra pr : link

As described in the official Redis documentation :
Redis LRU eviction is not a perfect LRU but use sampling : link
=> during the eviction process by default batchs of 5 random keys are challenged and the oldest one is removed
=> This can lead to data loss in our running job.
Depending of the user workload it can be helpful to expose the sampling number in the configuration of redis/elasticache
It will not fix the problem, but it will reduce the frequency of its occurrence.
test validation screenshot on AWS

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023

CLA assistant check
All committers have signed the CLA.

@ngruelaneo
Copy link
Contributor

Perhaps you should add this to the GCP deployment also?

@alouvion-aneo alouvion-aneo force-pushed the al/redis-maxmemory-samples-option-added branch from 1223b44 to be465bb Compare October 22, 2023 18:57
@alouvion-aneo
Copy link
Contributor Author

@alouvion-aneo alouvion-aneo force-pushed the al/redis-maxmemory-samples-option-added branch 2 times, most recently from fe5dc3f to fb138f8 Compare October 24, 2023 14:16
@alouvion-aneo alouvion-aneo force-pushed the al/redis-maxmemory-samples-option-added branch 2 times, most recently from 6a03650 to ed80df1 Compare November 7, 2023 19:23
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lemaitre-aneo lemaitre-aneo force-pushed the al/redis-maxmemory-samples-option-added branch from ed80df1 to 36c5845 Compare March 12, 2024 08:24
@lemaitre-aneo lemaitre-aneo force-pushed the al/redis-maxmemory-samples-option-added branch from 36c5845 to 93c97c5 Compare March 12, 2024 08:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lemaitre-aneo lemaitre-aneo merged commit 7eef4ba into main Mar 12, 2024
12 checks passed
@lemaitre-aneo lemaitre-aneo deleted the al/redis-maxmemory-samples-option-added branch March 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants