-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose max_memory_samples parameter for redis/elasticache #1227
Conversation
2fe30d4
to
1b720ff
Compare
Perhaps you should add this to the GCP deployment also? |
1223b44
to
be465bb
Compare
We can't set this variable on GCP |
fe5dc3f
to
fb138f8
Compare
6a03650
to
ed80df1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ed80df1
to
36c5845
Compare
36c5845
to
93c97c5
Compare
Quality Gate passedIssues Measures |
linked to infra pr : link
As described in the official Redis documentation :
Redis LRU eviction is not a perfect LRU but use sampling : link
=> during the eviction process by default batchs of 5 random keys are challenged and the oldest one is removed
=> This can lead to data loss in our running job.
Depending of the user workload it can be helpful to expose the sampling number in the configuration of redis/elasticache
It will not fix the problem, but it will reduce the frequency of its occurrence.
test validation screenshot on AWS