feat: Added SQS support to ArmoniK #1344
Conversation
AncientPatata
force-pushed
the
ad/sqs_testing
branch
3 times, most recently
from
13ffd16 to
7b1f85c
Compare
AncientPatata
force-pushed
the
ad/sqs_testing
branch
from
7b1f85c to
6879363
Compare
AncientPatata
changed the title
|
I would need to upgrade the version of Core to 0.29.1, and the ArmoniK.Infra PR would need to be merged first before merging this |
AncientPatata
force-pushed
the
ad/sqs_testing
branch
3 times, most recently
from
8929679 to
47ecef9
Compare
| @@ -143,6 +144,24 @@ module "mq" { | |||
| kms_key_id = local.kms_key | |||
| } | |||
|
|
|||
| module "sqs" { | |||
| count = length(var.sqs_service_account_name) > 0 ? 1 : 0 | |||
There was a problem hiding this comment.
| count = length(var.sqs_service_account_name) > 0 ? 1 : 0 | |
| count = can(coalesce(var.sqs_service_account_name)) ? 1 : 0 |
| } | ||
|
|
||
| module "sqs_service_account" { | ||
| count = length(var.sqs_service_account_name) > 0 ? 1 : 0 |
There was a problem hiding this comment.
| count = length(var.sqs_service_account_name) > 0 ? 1 : 0 | |
| count = can(colaesce(var.sqs_service_account_name)) ? 1 : 0 |
| @@ -76,4 +78,6 @@ module "armonik" { | |||
| image = local.ecr_images["${var.pod_deletion_cost.image}:${try(coalesce(var.pod_deletion_cost.tag), "")}"].image | |||
| tag = local.ecr_images["${var.pod_deletion_cost.image}:${try(coalesce(var.pod_deletion_cost.tag), "")}"].tag | |||
| }) | |||
|
|
|||
| depends_on = [module.sqs_service_account] | |||
There was a problem hiding this comment.
Since this module is optional, how is this dependency managed when the module is not deployed ?
There was a problem hiding this comment.
Wouldn't it be okay because the module is still deployed (just with count 0).. It's the same thing as the dependency you did with both mongodb and mongodb_sharded no? (We pass the two in even though we only deploy one of them)
versions.tfvars.json
Outdated
There was a problem hiding this comment.
I don't think such a PR should change so much versions
There was a problem hiding this comment.
You're right.. I think I should wait for the latest version of Core to be used in ArmoniK before merging though (and also of ArmoniK.Infra) since both are needed.
| type = string | ||
| default = "" |
There was a problem hiding this comment.
| type = string | |
| default = "" | |
| type = optional(string) |
There was a problem hiding this comment.
Keyword "optional" can only be used for object type attributes..
AncientPatata
force-pushed
the
ad/sqs_testing
branch
10 times, most recently
from
1edc0b4 to
2784f1a
Compare
AncientPatata
force-pushed
the
ad/sqs_testing
branch
from
2784f1a to
686c633
Compare
AncientPatata
force-pushed
the
ad/sqs_testing
branch
from
686c633 to
7c33da5
Compare
|
Motivation
SQS was added to ArmoniK.Core but was never supported in ArmoniK.Infra, now that SQS is added as a module to ArmoniK.Infra. This PR makes adjustments to ArmoniK to support these upcoming changes;
Description
Created instances of the SQS module/service account and made it toggleable through a variable. Since integrating SQS required creating a service account that will be used by ArmoniK's control and compute planes.
Testing
Tested, queue is being created, used and tasks are executed in ArmoniK.
Impact
TODO.
Additional Information
Not Applicable.
Checklist