Skip to content

Fix: Prevent 'Bearer' token prefix duplication #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent 'Bearer' token prefix duplication #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions SmartApi/smartConnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,20 @@ def _request(self, route, method, parameters=None):
# Custom headers
headers = self.requestHeaders()

if self.access_token:
# set authorization header
# if self.access_token:
# # set authorization header

auth_header = self.access_token
headers["Authorization"] = "Bearer {}".format(auth_header)
# auth_header = self.access_token
# headers["Authorization"] = "Bearer {}".format(auth_header)

if self.access_token:
# Set authorization header
# Check if 'Bearer' prefix is already present to prevent duplication
# Previously, 'Bearer' was being added indiscriminately, potentially causing
# issues like 'Bearer Bearer {token}' if the token already had the prefix
if not self.access_token.startswith("Bearer "):
self.access_token = "Bearer " + self.access_token
headers["Authorization"] = self.access_token

if self.debug:
log.debug("Request: {method} {url} {params} {headers}".format(method=method, url=url, params=params, headers=headers))
Expand Down