Skip to content

Change api to get ip address from ipify to amazonaws. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change api to get ip address from ipify to amazonaws. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0453b3
Change api to get ip address from ipify to amazonaws.
mittalshubham Jun 16, 2023
170fb3e
Better error handling for login
mittalshubham Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
.idea/smartapi-python.iml
build/*
smartapi_python.egg-info
dist/*
dist/*
.vscode/*
5 changes: 3 additions & 2 deletions SmartApi/smartConnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class SmartConnect(object):


try:
clientPublicIp= " " + get('https://api.ipify.org').text
clientPublicIp= " " + get('https://checkip.amazonaws.com').text
if " " in clientPublicIp:
clientPublicIp=clientPublicIp.replace(" ","")
hostname = socket.gethostname()
Expand Down Expand Up @@ -245,7 +245,8 @@ def generateSession(self,clientCode,password,totp):

return user
else:
return loginResultObject
raise Exception(loginResultObject)

def terminateSession(self,clientCode):
logoutResponseObject=self._postRequest("api.logout",{"clientcode":clientCode})
return logoutResponseObject
Expand Down