Skip to content

fix babyai score exceeds 1.0 in certain cases #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bob056192 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix babyai score exceeds 1.0 in certain cases #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agentenv-babyai/agentenv_babyai/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ def update(self, action, obs, reward, done, infos): # update the environment aft
else:
self.reward = reward

if self.done: # in case the model find a way to skip a step
if self.reward <= 0.5:
self.done = False
# if self.done: # in case the model find a way to skip a step
# if self.reward <= 0.5:
# self.done = False

if self.reward == 1 and not self.done: # if the agent has already reached the goal, but the task is not completed, we fix the error.
self.done = True
Expand Down