Skip to content

Conversation

@angrynode
Copy link
Owner

No description provided.

@angrynode
Copy link
Owner Author

Tests are failing because of tests/libtorrent/good/sample.torrent, which contains a tracker tracker.publicbt.com:80/announce (without scheme).

Some notes:

  • it appears in qBittorrent but unsupported URL protocol
  • it doesn't appear at all in Transmission
  • it appears in imdl

Two notes:

  • my bad for assuming sample.torrent was actually a good example, it's actually a bad one (i guess?)
  • maybe we can have relaxed scheme validation (eg. unknown scheme or no scheme) behind a feature flag? or not at all, but by default i believe this should fail to parse indeed

@angrynode
Copy link
Owner Author

added unknown_tracker_scheme crate feature which produces a new TrackerScheme::Unknown(String) variant.

There's tests for both cases.

@angrynode angrynode merged commit f4df806 into main Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants