Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Og image #368

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Og image #368

merged 3 commits into from
Sep 3, 2024

Conversation

geromegrignon
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@geromegrignon geromegrignon merged commit fdc24b1 into main Sep 3, 2024
1 check passed
@geromegrignon geromegrignon deleted the og-image branch September 3, 2024 08:20
@@ -25,6 +25,14 @@ export const routeMeta: RouteMeta = {
name: 'description',
content: 'Curated list of Angular Events',
},
{
property: 'og:title',
content: 'Title of the page',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, this should be replaced I guess? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha @ajitzero good catch. I was too excited to test it out when missed that detail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants