Repository navigation
fix(@angular/build): warn about unsupported options in the unit-test karma runner - #34546
Merged
alan-agius4 merged 3 commits intoOct 28, 2026
Merged
alan-agius4 merged 3 commits into
alan-agius4 merged 3 commits into
Conversation
…karma runner The karma runner silently ignored `providersFile`, `outputFile` and `coverageReporters`. For example, `ng test --runner karma --coverage --coverage-reporters lcov` wrote no `lcov.info` and printed nothing. Log the same "not supported" warning that the runner already logs for its other unsupported options.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds warning logs to the Karma executor when unsupported options (providersFile, outputFile, and coverage.reporters) are provided, along with corresponding unit tests. The feedback correctly identifies a potential runtime TypeError where optional chaining should be used when checking coverage.reporters, as coverage itself may be undefined.
…t-test karma runner Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
alan-agius4
requested changes
Oct 28, 2026
alan-agius4
added
action: cleanup
…t-test karma runner
alan-agius4
approved these changes
Oct 28, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The karma runner silently ignored
providersFile,outputFileandcoverageReporters. For example,ng test --runner karma --coverage --coverage-reporters lcovwrote nolcov.infoand printed nothing. Log the same "not supported" warning that the runner already logs for its other unsupported options.