Skip to content

fix(@angular/build): quote weak ETags of assets served by the dev server #34566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Oct 28, 2026
Merged

fix(@angular/build): quote weak ETags of assets served by the dev server #34566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c91b0
fix(@angular/build): quote weak ETags of assets served by the dev server
MeAkib Oct 28, 2026
a0c3ed2
fixup! fix(@angular/build): quote weak ETags of assets served by the …
MeAkib Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/dev-server/tests/behavior/build-assets_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupT

expect(result?.success).toBeTrue();
expect(await response?.text()).toContain(javascriptFileContent);
expect(response?.headers.get('ETag')).toMatch(/^W\/"[^"]+"$/);
Comment thread
MeAkib marked this conversation as resolved.
});

it('serves a project JavaScript asset unmodified', async () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function createAngularAssetsMiddleware(
// This is a workaround to serve extensionless, CSS, JS and TS files without Vite transformations.
if (!extension || JS_TS_REGEXP.test(extension) || CSS_PREPROCESSOR_REGEXP.test(extension)) {
const contents = readFileSync(asset.source);
const etag = `W/${calculateHash(contents)}`;
const etag = `W/"${calculateHash(contents)}"`;
if (checkAndHandleEtag(req, res, etag)) {
return;
}
Expand Down Expand Up @@ -238,7 +238,7 @@ export function createBuildAssetsMiddleware(
const contents =
outputFile.origin === 'memory' ? outputFile.contents : readHandler(outputFile.source);

const etag = `W/${calculateHash(contents)}`;
const etag = `W/"${calculateHash(contents)}"`;
if (checkAndHandleEtag(req, res, etag)) {
return;
}
Expand Down
Loading