Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JSNAMESPACE_SUPPORT from event-dispatch #55597

Closed

Conversation

rahatarmanahmed
Copy link
Contributor

This was an old feature that let you add jsnamespace="ns to an element to implicitly add the ns. namespace to all unnamespaced JSAction handlers on or under that element. This required an expensive DOM walk to find the jsnamespace, and almost all JSAction users turned this feature off. The last usage in google 3was removed, so we can delete this now.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

The usage of this option has been removed from google3 code, so we don't
need to keep it around anymore.
@pullapprove pullapprove bot requested review from atscott and neonstalwart April 30, 2024 20:13
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 30, 2024
@pullapprove pullapprove bot requested review from atscott and neonstalwart April 30, 2024 20:14
@rahatarmanahmed
Copy link
Contributor Author

Realized I need to delete references to the flag first even if its unused!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requires: TGP This PR requires a passing TGP before merging is allowed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant