Skip to content

Commit

Permalink
chore(release): update changelog and bump version to 12.1.9
Browse files Browse the repository at this point in the history
  • Loading branch information
@dgp1130
dgp1130 committed Feb 9, 2023
1 parent 50d87ad commit fff7682
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 12.1.9

Updates `adm-zip` to version `0.5.2`.

# 12.1.8

Fixes for macOS ChromeDriver download. If you are using a macOS and are
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webdriver-manager",
"version": "12.1.8",
"version": "12.1.9",
"description": "A selenium server and browser driver manager for your end to end tests.",
"scripts": {
"format": "gulp format",
Expand Down

7 comments on commit fff7682

@bparrish99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of this update, "webdriver-manager update" fails with:

Error: Cannot find module 'rimraf'

@dgp1130
Copy link
Collaborator Author

@dgp1130 dgp1130 commented on fff7682 Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparrish99, I don't believe this version should change anything with repsect to rimraf, and testing it out works for me as expected. If this is still happening for you, can you create a minimal reproduction and file an issue about it?

@bparrish99
Copy link

@bparrish99 bparrish99 commented on fff7682 Feb 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting. If I specify the version 12.1.9 when I install, it works fine. But if I install just with "npm i -g webdriver-manager", running any webdriver-manager command throws the error.

I can move this over to an issue unless I'm just doing something dumb.

Screen.Recording.2023-02-09.at.3.40.27.PM.mp4

@cnishina
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi bparrish99,

After watching the video, webdriver-manager by itself is not a valid command. Maybe try to use a command like webdriver-manager update? Why it can't find the rimraf node module is unusual since it is a dependency defined in the package.json. Maybe if you tried webdriver-manager clean, that should use the rimraf module to remove files.

@dgp1130
Copy link
Collaborator Author

@dgp1130 dgp1130 commented on fff7682 Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce on [email protected]. I think your npm install -g webdriver-manager was pulling in the latest version, which is 13.0.1, not 12.1.9.

$ npm install [email protected]
$ node_modules/.bin/webdriver-manager update
Error: Cannot find module 'rimraf'

Interestingly, it looks like rimraf is listed as a dev dependency in 13.0.1 (unpkg) and so would not be installed in this context. It's also a dev dependency in 13.0.0, but I can't reproduce the error with that version, so I'm guessing we're not require()-ing it in 13.0.0.

I think this was introduced by e2c7d2b, an older commit but left over after 13.0.0 and never released. Our options are either:

  1. Move rimraf to regular dependencies and hope none of the other commits after 13.0.0 have any bugs.
  2. Branch off 13.0.0 and just land the adm-zip dependency bump.

@dgp1130
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted all the unreleased commits after 13.0.0 except for the adm-zip bump and published that as 13.0.2. With that I'm able to install and update as expected. Hopefully that should fix your issue @bparrish99.

@bparrish99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please sign in to comment.