Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Zulip.js #180

Closed
wants to merge 6 commits into from
Closed

Updated Zulip.js #180

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
297e594
Updated Zulip.js
msaini28r Oct 15, 2021
34d8cb3
Update Zulip.js
msaini28r Oct 15, 2021
9593b3f
Delete Zulip.js
msaini28r Oct 15, 2021
5b176e1
Revert "Delete Zulip.js"
msaini28r Oct 15, 2021
caf53a6
Update Zulip.js
msaini28r Oct 16, 2021
f9fa49e
Update Zulip.js
msaini28r Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/Zulip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,23 @@ class Zulip extends Component {
<ul>
<li>
<b>#newcomers: </b>
{zulipstat[0] ? zulipstat[0].newcomers_messages : 0}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this?
You need to change the condition so that it can render without any errors.

{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

Same change for other lines also.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesankalp can you please check if I made the right changes?

{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks repeated for zulipstat && zulipstat[0]. Can you please remove this zulipstat && zulipstat[0] from each line and add zulipstat && zulipstat[0] in parent tag (ul)?

Suggested change
{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}
{zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesankalp check now changes done.

</li>
<li>
<b>#celebrate: </b>
{zulipstat[0] ? zulipstat[0].celebrate_messages : 0}
{zulipstat && zulipstat[0] && zulipstat[0].celebrate_message ? zulipstat[0].celebrate_message : 0}
</li>
<li>
<b>#opportunities: </b>
{zulipstat[0] ? zulipstat[0].opportunities_messages : 0}
{zulipstat && zulipstat[0] && zulipstat[0].opportunities_message ? zulipstat[0].opportunities_message : 0}
</li>
<li>
<b>#questions: </b>
{zulipstat[0] ? zulipstat[0].questions_messages : 0}
{zulipstat && zulipstat[0] && zulipstat[0].questions_message ? zulipstat[0].questions_message : 0}
</li>
<li>
<b>#general: </b>
{zulipstat[0] ? zulipstat[0].general_messages : 0}
{zulipstat && zulipstat[0] && zulipstat[0].general_message ? zulipstat[0].general_message : 0}
</li>
</ul>
</>
Expand Down