-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Prettier note on Contributing doc #324
base: develop
Are you sure you want to change the base?
Conversation
@brittanyjoiner15 Soo I may just contradict the very things that I wrote in the doc lol. Umm should I get rid of this PR and try to have Prettier installed? I'm afraid that I may have messed up on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Menina294 this is looking good :) I think you could also include a section on the README, explaining is the command to install and run prettier. You could do:
### Run linter
To install linter run this command: `yarn install prettier`
To run, use this command: `prettier ...`
I am not sure what are the exact commands, but this is an idea of how it could look like :)
cc @brittanyjoiner15
@isabelcosta and @Menina294 we actually might want to put this on hold until we figure out what's happening with #325 - just in case that changes anything, but yes in general I think you probably should just need some lines like @isabelcosta drafted above! I think the additional line would be the prettier write command, which I'm adding in here:
@Menina294 let me know if you need any help with the commits and stuff! I know it's a little nerve-wracking sometimes. I prefer using the Github Desktop client, because it helps make it more clear! But basically you'll create a new branch, then make changes to your code in your editor (basically adding the section above into the |
Ahh okay. Thanks for letting me know @brittanyjoiner15! |
Description
Include a text about having Prettier installed and reminder to run write and check functions on current file(s).
Fixes #317
Type of Change:
How Has This Been Tested?
Checklist: