-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add pretty-quick dependency #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 % agree with this. I think i am not very familiar with GH actions, so probably should not have implemented that to start with, so my apologies 😭 . Glad we have something else in place that @ftonato seems more familiar with! I am good with this!
No need for apologies @brittanyjoiner15 thank you for working on this and being so proactive 💯 |
Explanatory note: The contributor doesn't need to do anything, when they commits the command will be trigged automatically (unless they say that they want to ignore it being executed with the /c @isabelcosta |
@ftonato won't they have to run "husky install" (from line |
do you use npm to regenerate dependencies, I was trying now. and Can you regenerate using that? |
@ftonato just as fyi I just removed the gh action prettier job to unblock deployments. This PR is still valid, let me know what you think when you have the time |
It's like I said, they don't need to do anything. I use NPM, but I can test with YARN to see that no problems happen. See the example flow below:
I knew the file didn't follow the expected formatting, and when I tried to run / c @isabelcosta |
Really appreciate your efforts @ftonato 👏 |
I'm closing outdated issues and pull-requests that are no longer relevant given how much time has passed since they were opened. |
Description
We are adding "pretty-quick" as an alternative to "Prettier Action", your responsibility is to run "prettier" when we change any file (respecting the defined default) when we commit it, thus maintaining consistency between all commits.
Fixes #326
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
.js
fileChecklist:
/c @isabelcosta & @brittanyjoiner15