Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech talk component in the events page #145

Closed
wants to merge 8 commits into from

Conversation

imrishabh18
Copy link

@imrishabh18 imrishabh18 commented Sep 15, 2020

Description

I have made the carousel with proper props and state. Some styling is still left as I was not getting the proper colors. Will be helpful if you can send me those as well as the video links. For the time being, I have used a random photo.

Fixes #122

Type of Change:

  • Code
  • User Interface

Checklist:

  • [✅ ] My PR follows the style guidelines of this project
  • [ ✅] I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

@imrishabh18
Copy link
Author

Hey @nandini45 , review this PR please 😃

@nandini45
Copy link
Member

@imrishabh18 can you recheck your travis check it is failing?

@imrishabh18
Copy link
Author

@nandini45 I am not able to resolve why this travis build check fails. Can you help me with this?

@nandini45 nandini45 requested a review from annabauza September 19, 2020 17:24
@nandini45
Copy link
Member

yeah sure @imrishabh18
can you tell me where did you get the image you used?

@imrishabh18
Copy link
Author

It is link from unsplash

@nandini45
Copy link
Member

i dont think we can do. did you check the repository ?
was there any image which you can use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coding: develop the tech talk section in events page
2 participants