Tech Talk page #147
Closed
Tech Talk page #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nandini45 I have made a new PR because that branch had some messed up changes. Here, I have removed the unsplash images link too. Even after that It has some build error. |
Akanksha1212
added
the
Status: Needs Review
annabauza
requested changes
Oct 24, 2020
annabauza
added
Status: Changes Requested
|
@imrishabh18 Can you make the requested changes? |
isabelcosta
reviewed
Dec 22, 2020
There was a problem hiding this comment.
@imrishabh18 in GitHub if you refer to issues in the PR description like: Fixes #122 GitHub will close the issue once the PR is merged, so I changed that in your PR. Now you can follow this practice in future PRs :)
|
@imrishabh18 thank u for the work. Because of your unavailability i will close the pr. Reopen this isse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have made the carousel with proper props and state. Some styling is still left as I was not getting the proper colors. Will be helpful if you can send me those as well as the video links. For the time being, I have used a random photo.
Fixes #122
Type of Change:
Checklist: