Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): reduced 94% and 50% of a11y issues on 'About Us' and 'Cont… #380

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(a11y): reduced 94% and 50% of a11y issues on 'About Us' and 'Cont… #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Components/AboutUs/Oscommunity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function MembersIcon(props) {
return (
<View style={styles.container}>
<a target="_blank" rel="noopener noreferrer" href={props.html_url}>
<Image style={styles.image} source={props.avatar_url} />
<Image style={styles.image} source={props.avatar_url} accessibilityLabel={`Github account of ${props.login}`} />
</a>
</View>
);
Expand All @@ -20,8 +20,8 @@ function OSCommunity() {
.then((response) => response.json())
.then((response) => {
var osdata = [];
response.forEach(({ id, avatar_url, html_url }) => {
osdata.push({ id, avatar_url, html_url });
response.forEach(({ id, avatar_url, html_url, login }) => {
osdata.push({ id, avatar_url, html_url, login });
});
setData(osdata);
})
Expand Down
2 changes: 1 addition & 1 deletion src/Components/AboutUs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function AboutUs() {
{section.content.map((content, indx) => {
return (
<Hyperlink
linkStyle={{ color: '#2980b9' }}
linkStyle={{ textDecoration: 'underline' }}
onPress={(url) => window.open(url, '_blank')}
>
<Description key={indx}>{content.par}</Description>
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Contribute/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function Contribute() {
{section.content.map((content, index) => {
return (
<Hyperlink
linkStyle={{ color: '#2980b9' }}
linkStyle={{ textDecoration: 'underline' }}
onPress={(url) => window.open(url, '_blank')}
>
<Description key={index}>{HTMLReactParser(content.par)}</Description>
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Footer/Contact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function Contact() {
<Text style={[styles.text, styles.heading]}>Contact Us</Text>
{content.map((content, i) => (
<Hyperlink
linkStyle={{ color: '#2980b9' }}
linkStyle={{ textDecoration: 'underline' }}
onPress={(url) => window.open(url, '_blank')}
>
<Text style={[styles.text, styles.description]} key={i}>
Expand Down
14 changes: 7 additions & 7 deletions src/test/__snapshots__/AboutUs.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand Down Expand Up @@ -129,7 +129,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand All @@ -155,7 +155,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand Down Expand Up @@ -206,7 +206,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand All @@ -216,7 +216,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand Down Expand Up @@ -253,7 +253,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
https://medium.com/anitab-org-open-source
Expand Down Expand Up @@ -341,7 +341,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
http://anitab-org.zulipchat.com
Expand Down
8 changes: 4 additions & 4 deletions src/test/__snapshots__/Contribute.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand All @@ -92,7 +92,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand All @@ -102,7 +102,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
https://github.com/anitab-org
Expand Down Expand Up @@ -139,7 +139,7 @@ exports[`should take a snapshot 1`] = `
class="css-text-901oao css-textHasAncestor-16my406 r-cursor-1loqt21"
data-focusable="true"
dir="auto"
style="color: rgb(41, 128, 185);"
style="text-decoration: underline;"
tabindex="0"
>
AnitaB.org
Expand Down
Loading