Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added toast message for "no skills' filter #1173

Closed
wants to merge 4 commits into from
Closed

Fix: Added toast message for "no skills' filter #1173

wants to merge 4 commits into from

Conversation

SubhraPriyadarshinee
Copy link

@SubhraPriyadarshinee SubhraPriyadarshinee commented Oct 24, 2021 •
edited
Loading

Description

  • Found similar code for "location filter"
  • Copy pasted the same code below that

Fixes #866

Type of Change:

  • Code

How Has This Been Tested?

  • Open app -> Go to members page -> open filter -> type anything on "skills" box that has zero results -> now it will show a toast message

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@SubhraPriyadarshinee
fix: Toast message for "no skills" filter
8c0ed85 
Found similar code for "location" filter.
Copy pasted the same code below that.
@SubhraPriyadarshinee
fix: Toast message for "no skills" filter
ce93aef 
Found similar code for "location" filter.
Copy pasted the same code below that.
@SubhraPriyadarshinee
fix: Toast message for "no skills" filter
56c84d0 
Found similar code for "location" filter.
Copy pasted the same code below that.
@SubhraPriyadarshinee SubhraPriyadarshinee mentioned this pull request Oct 24, 2021
Open
@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 25, 2021
epicadk
epicadk previously approved these changes Oct 25, 2021
View reviewed changes
@epicadk epicadk requested a review from vj-codes October 25, 2021 08:01
vj-codes
vj-codes previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @SubhraPriyadarshinee 🎉

@vj-codes vj-codes added Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Oct 25, 2021
@vj-codes
Copy link
Member

@SubhraPriyadarshinee please update the PR description to Fixes #866 so that this PR gets linked with the issue

@SubhraPriyadarshinee
fix: Validation of Task Description text before posting it to backend
d612ff6 
Checked if textview is empty or not.
If empty, a toast message is shown.
Else, task is added.
@SubhraPriyadarshinee SubhraPriyadarshinee dismissed stale reviews from vj-codes and epicadk via d612ff6 October 30, 2021 19:11
@SubhraPriyadarshinee
Copy link
Author

Hello, Can you please delete the last pull request for fix #879 . I was trying to make a PR but it accidentally got merged with this one.

@SubhraPriyadarshinee
Copy link
Author

Hello, Can you please delete the last pull request for fix #879 . I was trying to make a PR but it accidentally got merged with this one.

@vj-codes @epicadk

@vj-codes
Copy link
Member

@SubhraPriyadarshinee I am not sure what do you mean by "delete PR", please elaborate:)

@SubhraPriyadarshinee
Copy link
Author

@SubhraPriyadarshinee I am not sure what do you mean by "delete PR", please elaborate:)
Actually, I was making a different PR for a different issue but somehow it got merged with this one and is showing these errors.

@vj-codes
Copy link
Member

@SubhraPriyadarshinee can you try reverting the last commit?

@vj-codes vj-codes added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Nov 23, 2021
@vj-codes
Copy link
Member

Closing this PR due to inactivity.
Thank you for your contribution @SubhraPriyadarshinee :)

@vj-codes vj-codes closed this Jan 27, 2022
@abhilipsasahoo03 abhilipsasahoo03 mentioned this pull request Jul 12, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes left review comments

@epicadk epicadk epicadk left review comments

@isabelcosta isabelcosta Awaiting requested review from isabelcosta isabelcosta is a code owner

Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add toast message when no user with common skills is found using filter
3 participants
@SubhraPriyadarshinee @vj-codes @epicadk