test: Add test emulators to Travis CI configuration #696

gaurivn · 2020-04-19T20:53:51Z

Description

Added test emulators to Travis CI configuration.

Fixes #168

Type of Change:

Delete irrelevant options.

Code

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

Code/Quality Assurance Only

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

atm1504

LGTM. Good Work : )

atm1504 · 2020-04-22T22:49:28Z

@gaurivn can you please try to fix the Travis build error. Else everything looks good to me.

gaurivn · 2020-04-22T23:29:09Z

Thank you @atm1504 , actually in my first commit, I had included test. The build error I got was that no test.ini file exists in $HOME/.android/avd. I searched, couldn't find how to create the test.ini file, so I replaced test with the name of an emulator (whose .avd and .ini files exist in my $HOME/.android/avd) but again I am getting error in travis that that .ini file cannot be found. Please help me solve this issue, how to go about creating the test.ini file.

gaurivn · 2020-04-30T21:49:01Z

@isabelcosta , can you please help me solve the travis build error, in the first commit I had written correctly with 'test' and Travis build gives error saying that test.ini file didn't exist in my $HOME/.android/avd and I checked it wasn't there.

So just to confirm again, I committed a second time, with my emulator (Nexus 5 full name - exactly how it was in the .ini files at $HOME/.android/avd) and still Travis Build says the files does not exist.

Can you please tell me how to create the test.ini file, I tried searching but couldn't find.

isabelcosta · 2020-05-01T11:52:22Z

🤔 at this moment I am not sure what the problem is, so I will call out help here @annabauza @foongminwong and on Zulip @gaurivn

devansh-299 · 2020-05-01T12:11:56Z

@gaurivn
The problem is most probably because you havent't specified the emulator level under components. Also before running the script you need to initialise the virtual running environment which can be done as - echo no | android create avd --force -n test -t android-<your emulator level> --abi <your abi level>

gaurivn · 2020-05-01T12:54:10Z

Thank you so much @isabelcosta 🙏

gaurivn · 2020-05-01T12:58:32Z

@devansh-299 , thank you, in my first commit, I had written properly with test but it came test.ini file not there in $HOME/.android/avd. So I checked there, since my Nexus 5 emulator.ini file was there so I simply changed from test to Nexus 5...... in 2nd commit. Though the .ini file existed at the same location for Nexus 5, Travis shows it cannot find the same.

I will change it back to first commit and also rename my Nexus 5 .... .ini file to test.ini, that idea never occurred to me before, keeping in mind the points you said.

gaurivn · 2020-05-01T14:26:13Z

@devansh-299 , please find the screenshot attached below, grateful if you could comment on it, if I've to make more changes. I added android-30 (my emulator level) too afterwards.

devansh-299 · 2020-05-01T15:14:09Z

.travis.yml

@@ -6,12 +6,18 @@ android:
    - tools
    - build-tools-28.0.3
    - android-28
+    - android-30


I would suggest you to use some lower level of Emulator as it may lead to compatibility issues

I installed Pixel 3a emulator android-28, and removed the android-30 line, that would do.

@gaurivn this has nothing to do with your the emulator on your system. Here you are just specifying emulator specifications that would run on Docker on Travis' servers. I hope this explanation helps :)

devansh-299 · 2020-05-01T15:15:22Z

.travis.yml

@@ -6,12 +6,18 @@ android:
    - tools
    - build-tools-28.0.3
    - android-28
+    - android-30
+    - sys-img-x86-android-27


Since most android devices are based on arm processors, please use sys-img-armeabi-v7a-android-<your emulator level>

Since my emulator level, the one present currently in .travis.yml, and the one suggested in the comment linked to issue #168 - 131 is x86 I used that. Please let me know if I still have to change it to armeabi-v7a.

You should change it as the x86 abi image is invalid Error: Invalid --abi x86 for the selected target is occurring, you can checkout this from here

I had seen the error but before that when I ran with x86 the error was a kernel qemu file missing following which I read an answer on Travis Build working only till 27, that's why I didn't change it. I will change to to armeabi-v7a.

$ echo no | android create avd --force -n test -t android-27 --abi armeabi-v7a Valid ABIs: no ABIs. Error: Invalid --abi armeabi-v7a for the selected target. The command "echo no | android create avd --force -n test -t android-27 --abi armeabi-v7a" failed and exited with 1 during .
The emulator whose ini file I renamed to test.ini has the following specs.

devansh-299 · 2020-05-01T15:17:21Z

.travis.yml

 before_install:
 - yes | ${ANDROID_HOME}/tools/bin/sdkmanager "platforms;android-28"
+ - emulator -avd test -no-audio -no-window &


Please move 13, 14 lines below 16 line as currently, this is trying to initiate the emulator before creating the virtual environment

devansh-299 · 2020-05-01T15:18:08Z

.travis.yml

 before_script:
+ - echo no | android create avd --force -n test -t android-30 --abi x86


please replace the abi level here with the suggested one

isabelcosta · 2020-05-01T16:55:34Z

@devansh-299 thank you so much for your review here 🙌

gaurivn · 2020-05-02T08:42:32Z

@devansh-299 , thank you very much for the review, will need your help later on. I got the error that kernel-qemu file is missing, I'll try solving that and use armeabi-v7a.

devansh-299 · 2020-05-02T10:35:13Z

.travis.yml

@@ -5,13 +5,17 @@ android:
    - platform-tools
    - tools
    - build-tools-28.0.3
-    - android-28


Also, you have to specify the API level and the emulator level, so please do not delete -android-<level>. You need to specify for both of these separately, so you will have to add these lines
-android-<your_API_level>
-android-<your_emulator_level>
I hope this helps :)

- android-28
- android-27
Okay will add back.

devansh-299 · 2020-05-02T12:18:18Z

@gaurivn Error: Invalid --abi armeabi-v7a for the selected target. seems to be a common error, see this StackOverflow thread. Here's one .travis.yml script that worked for me, maybe you can use this

gaurivn · 2020-05-02T16:20:02Z

Thank you @devansh-299 , I'll make changes according to the script you provided. In case that doesn't work, then I'll follow the stack overflow one.

devansh-299 · 2020-05-03T13:35:45Z

@gaurivn @isabelcosta @anitab-org/coding-team the problem with the .travis.yml has been fixed but build is failing as the code is failing tests just added, see the report here. I think separate PRs should be addressed to fix the build issues

devansh-299 · 2020-05-03T13:36:39Z

@gaurivn please squash the commits

gaurivn · 2020-05-03T14:39:45Z

@devansh-299 , I was thinking of committing again by adding google_apis-google-21 etc. to see if it works. Do you suggest I try again, changing android-22 to the one I said or do I squash all the commits made so far

gaurivn · 2020-05-03T14:58:20Z

@gaurivn please squash the commits

Done

isabelcosta · 2020-05-03T15:07:39Z

@gaurivn @isabelcosta @anitab-org/coding-team the problem with the .travis.yml has been fixed but build is failing as the code is failing tests just added, see the report here. I think separate PRs should be addressed to fix the build issues

Thank you so much @devansh-299 for helping @gaurivn in this PR 🙌
What do you propose then, should we hold on this PR and have a separate issue/PR to fix the tests, then merge and then see if Travis CI build for this test emulators PR passes. If all good then merge this one?

devansh-299 · 2020-05-03T17:23:15Z

@gaurivn @isabelcosta @anitab-org/coding-team the problem with the .travis.yml has been fixed but build is failing as the code is failing tests just added, see the report here. I think separate PRs should be addressed to fix the build issues

Thank you so much @devansh-299 for helping @gaurivn in this PR raised_hands
What do you propose then, should we hold on this PR and have a separate issue/PR to fix the tests, then merge and then see if Travis CI build for this test emulators PR passes. If all good then merge this one?

Welcome, @isabelcosta :)
Yes, I think we can refer to the test results from this PR to fix the build failures with new PRs and then merge this PR. @anitab-org/coding-team should we go with this approach?

Hyper-Matrix · 2020-05-04T03:58:25Z

@devansh-299 agreed

… into patch_two

isabelcosta · 2020-05-08T12:36:15Z

@anitab-org/coding-team @devansh-299 can anyone here create the issues for fixing the tests that are failing? I am not sure which tests are failing, and I am low on bandwidth for this

devansh-299 · 2020-05-08T16:17:28Z

@anitab-org/coding-team @devansh-299 can anyone here create the issues for fixing the tests that are failing? I am not sure which tests are failing, and I am low on bandwidth for this

@isabelcosta sure! I will work on this

isabelcosta · 2020-12-13T00:38:56Z

@gaurivn are you interested in continuing this issue?
If yes, could you please change this PR to make the tests run on GitHub actions? If not, please let me know so I can close this. I was thinking of creating a new issue to make this using GH actions, but if you can do this here, I don't mind if you do this here. What do you think?

gaurivn · 2020-12-13T06:22:32Z

@gaurivn are you interested in continuing this issue?
If yes, could you please change this PR to make the tests run on GitHub actions? If not, please let me know so I can close this. I was thinking of creating a new issue to make this using GH actions, but if you can do this here, I don't mind if you do this here. What do you think?

@isabelcosta, I won't be able to continue this issue for the time being, pls feel free to close this PR.

isabelcosta · 2020-12-14T18:13:16Z

@isabelcosta, I won't be able to continue this issue for the time being, pls feel free to close this PR.

@gaurivn no problem! thank you for letting me know 🤗
I will close it then

gaurivn force-pushed the patch_two branch from 1799837 to f539fc1 Compare April 20, 2020 10:19

atm1504 previously approved these changes Apr 22, 2020

View reviewed changes

gaurivn dismissed atm1504’s stale review via e99f930 May 1, 2020 14:31

devansh-299 suggested changes May 1, 2020

View reviewed changes

devansh-299 reviewed May 2, 2020

View reviewed changes

test emulator

7082f84

gaurivn force-pushed the patch_two branch from 89df837 to 7082f84 Compare May 3, 2020 14:57

Merge branch 'develop' of https://github.com/systers/mentorship-android…

8e688d7

… into patch_two

devansh-299 mentioned this pull request May 9, 2020

Make all current failing Espresso Tests pass #704

Open

devansh-299 added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Testing UI Tests, Integration Tests, Travis CI, etc. labels May 9, 2020

menina763 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label May 27, 2020

isabelcosta closed this Dec 14, 2020

		before_script:
		- echo no \| android create avd --force -n test -t android-30 --abi x86

test: Add test emulators to Travis CI configuration #696

test: Add test emulators to Travis CI configuration #696

Conversation

gaurivn commented Apr 19, 2020

Description

Type of Change:

How Has This Been Tested?

Checklist:

atm1504 left a comment

Choose a reason for hiding this comment

atm1504 commented Apr 22, 2020

gaurivn commented Apr 22, 2020

gaurivn commented Apr 30, 2020

isabelcosta commented May 1, 2020

devansh-299 commented May 1, 2020 • edited Loading

gaurivn commented May 1, 2020

gaurivn commented May 1, 2020

gaurivn commented May 1, 2020 • edited Loading

Choose a reason for hiding this comment

gaurivn May 2, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devansh-299 May 1, 2020 • edited Loading

Choose a reason for hiding this comment

isabelcosta commented May 1, 2020

gaurivn commented May 2, 2020

Choose a reason for hiding this comment

gaurivn May 2, 2020 • edited Loading

Choose a reason for hiding this comment

devansh-299 commented May 2, 2020

gaurivn commented May 2, 2020

devansh-299 commented May 3, 2020

devansh-299 commented May 3, 2020

gaurivn commented May 3, 2020

gaurivn commented May 3, 2020

isabelcosta commented May 3, 2020

devansh-299 commented May 3, 2020

Hyper-Matrix commented May 4, 2020

isabelcosta commented May 8, 2020

devansh-299 commented May 8, 2020 • edited Loading

isabelcosta commented Dec 13, 2020

gaurivn commented Dec 13, 2020

isabelcosta commented Dec 14, 2020

devansh-299 commented May 1, 2020 •

edited

Loading

gaurivn commented May 1, 2020 •

edited

Loading

gaurivn May 2, 2020 •

edited

Loading

devansh-299 May 1, 2020 •

edited

Loading

gaurivn May 2, 2020 •

edited

Loading

devansh-299 commented May 8, 2020 •

edited

Loading