Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs : added badges in the documentation #749

Merged
merged 3 commits into from
Aug 24, 2020
Merged

docs : added badges in the documentation #749

merged 3 commits into from
Aug 24, 2020

Conversation

CodeChamp-SS
Copy link
Contributor

@CodeChamp-SS CodeChamp-SS commented Aug 10, 2020 •
edited
Loading

Description

Fixes #746

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • My changes generate no new warnings

@CodeChamp-SS
Copy link
Contributor Author

@vj-codes pls review this pr

vj-codes
vj-codes requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeChamp-SS Congrats on your first contribution to the repo!!
Looks good , just update the zulip link to Mentorship system stream , this is the correct one https://anitab-org.zulipchat.com/#narrow/stream/222534-mentorship-system
And then you are done!
Also ,please remember to wait until a issue is assigned to you and then send a PR next time. Assigned it now so it'll review this time only.

@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Aug 10, 2020
@CodeChamp-SS
Copy link
Contributor Author

@CodeChamp-SS Congrats on your first contribution to the repo!!
Looks good , just update the zulip link to Mentorship system stream , this is the correct one https://anitab-org.zulipchat.com/#narrow/stream/222534-mentorship-system
And then you are done!
Also ,please remember to wait until a issue is assigned to you and then send a PR next time. Assigned it now so it'll review this time only.

sure i'll wait till the issue is assigned to me from next time. And i'll do the required change

vj-codes
vj-codes previously approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

anna4j
anna4j previously approved these changes Aug 19, 2020
View reviewed changes
@anna4j anna4j added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Aug 19, 2020
@anna4j
Copy link

anna4j commented Aug 22, 2020

@isabelcosta This PR is ready to merge!

isabelcosta
isabelcosta requested changes Aug 23, 2020
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeChamp-SS thank you for your contribution 🎉
Could you please address the request change? After this I can approve :)

README.md Outdated

[![project chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://anitab-org.zulipchat.com/#narrow/stream/222534-mentorship-system)
[![License: GPL v3](https://img.shields.io/badge/License-GPL%20v3-blue.svg)](http://www.gnu.org/licenses/gpl-3.0)
![Run tests](https://img.shields.io/badge/Run%20tests-passing-green)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Run tests](https://img.shields.io/badge/Run%20tests-passing-green)

Until we have Travis CI running tests, its best to take this out. We are waiting for this issue #704 to be fixed so that we can run tests on the build.

README.md Outdated
[![project chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://anitab-org.zulipchat.com/#narrow/stream/222534-mentorship-system)
[![License: GPL v3](https://img.shields.io/badge/License-GPL%20v3-blue.svg)](http://www.gnu.org/licenses/gpl-3.0)
![Run tests](https://img.shields.io/badge/Run%20tests-passing-green)
![Open Source Love](https://badges.frapsoft.com/os/v1/open-source.svg?v=102)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Open Source Love](https://badges.frapsoft.com/os/v1/open-source.svg?v=102)

This resource is not being successfully fetched, so its best to take it out.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vj-codes is this the correct link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya sure @isabelcosta , so i shall remove both open source love and run tests badge, right ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please :) @CodeChamp-SS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabelcosta made the required changes, please review :-)

@isabelcosta
Copy link
Member

@anna4j thank you for pinging me and sorry for taking so long! I requested some little changes and explained in the comments, after @CodeChamp-SS addresses it, I can gladly approve this :)

@vj-codes vj-codes added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Aug 24, 2020
@CodeChamp-SS
docs : removed 2 badges
a506fa3 
removed open source love and run tests badges
@CodeChamp-SS CodeChamp-SS dismissed stale reviews from anna4j and vj-codes via a506fa3 August 24, 2020 18:30
isabelcosta
isabelcosta approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @CodeChamp-SS 🎉
Thank you for your contribution!

@isabelcosta isabelcosta requested review from anna4j and vj-codes August 24, 2020 19:19
vj-codes
vj-codes approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isabelcosta isabelcosta added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Aug 24, 2020
@isabelcosta isabelcosta merged commit ec4e2f1 into anitab-org:develop Aug 24, 2020
@isabelcosta
Copy link
Member

@CodeChamp-SS your PR was merged 👏 Thank you again for your contribution!

@CodeChamp-SS CodeChamp-SS deleted the CodeChamp-SS-updating-readme branch August 25, 2020 08:43
@CodeChamp-SS CodeChamp-SS restored the CodeChamp-SS-updating-readme branch August 26, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes approved these changes

@isabelcosta isabelcosta isabelcosta approved these changes

@anna4j anna4j Awaiting requested review from anna4j

Assignees
No one assigned
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add badges in Readme.md
4 participants
@CodeChamp-SS @anna4j @isabelcosta @vj-codes