fix:Add toast message when no user with common skills is found using filter(anita-org#866)

[ritvij14]

Description

Added Toast for the situation when members with common skills are not found.

Fixes #866

Type of Change:

• Code

Code/Quality Assurance Only

• Bug-fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested it manually on my device Redmi Note 8 Pro. Video

Checklist:

Delete irrelevant options.

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials
• Any dependent changes have been merged

Code/Quality Assurance Only

• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

[spacemonkey1101]

is this issue open?

[mtreacy002]

@ritvij14 , I've tested this PR locally on a Pixel 2 emulator. I found a bug in the code that the toast Ooops! Not found pop up not only when the filter is applied, but even before that (when logged-in user select Members icon from the bottom Navbar). Can you please fix this? Thanks

cc @anna4j and @sanchi0204

[ritvij14]

@mtreacy002 sorry for the late response 😅

Could you please guide me as to where should I add the toast to not face this bug? I am really confused.

[mtreacy002]

@ritvij14 , when you run the app with the debugger, you can see that on its initial state when user first click the Members page (providing the app is newly installed, to avoid getting side effect from cache of previous actions), the filterMap on line 119 of MembersFragment will show only '"sort_key" -> "REGISTRATION_DATE"` as the filter condition.

Then when you type in a specific filter, the filterMap will show 3 other attributes with "skills" showing the string you just typed (in my example its "python").

Even if user clear all filters, the filterMap will show all 4 attributes (sort_key + 3 filters) but with filters getting empty strings.

You can use this information to place an if condition to check the status of filterMap and apply toast only when the desired filter exist in filterMap and not an empty string.

Hope this helps

[ritvij14]

@mtreacy002 thanks for the clarification, I will add an if condition for the filters. But this bug didn't happen on my device, is that because of different data in the recycler view or something else?

[mtreacy002]

@ritvij14 . I tested the latest change but the toast ended up not showing at all, both on initial click to Members page and after the filter is applied.

• tested with debug_localhost as active build variant
  

• tested with debug as active build variant
  

Can you please fix this?

[ritvij14]

@mtreacy002 yeah sorry about that 😅 I didn't notice that I had placed the wrong condition there. I have changed it and this is the current look. Does it look ok now?

[CodeChamp-SS]

LGTM ! Tested locally on emulator as well. Thanks @ritvij14 for your contribution.

[vj-codes]

@CodeChamp-SS can you please add a gif if you've tested on emulator just to crosscheck it's functionality, thanks!

[CodeChamp-SS]

@CodeChamp-SS can you please add a gif if you've tested on emulator just to crosscheck it's functionality, thanks!

on testing in different scenarios, I found a bug 😅. Even when the result is found, the toast pops up.

@ritvij14 can you please fix it ? I'll be happy to test again once you've fixed this issue :-)

pr884.testing.mp4

[ritvij14]

@CodeChamp-SS yes ok I will have a look once again and get back to you, will try to correct the errors asap.

[vj-codes]

@CodeChamp-SS thanks for uploading it :)

[ritvij14]

@CodeChamp-SS in the most recent pull of the latest code, my Gradle build is getting stopped and failing showing this error:-
Gradle sync failed: Gradle build daemon disappeared unexpectedly

This is not happening in other android projects on my system.

[CodeChamp-SS]

@CodeChamp-SS in the most recent pull of the latest code, my Gradle build is getting stopped and failing showing this error:-
Gradle sync failed: Gradle build daemon disappeared unexpectedly

This is not happening in other android projects on my system.

do one thing revert all the commits from your branch, then pull the develop branch, then commit your changes. Then try to build, ig that should fix the problem. If your changes are working as expected then do force push on the branch

[ritvij14]

@CodeChamp-SS in the most recent pull of the latest code, my Gradle build is getting stopped and failing showing this error:-
Gradle sync failed: Gradle build daemon disappeared unexpectedly
This is not happening in other android projects on my system.

do one thing revert all the commits from your branch, then pull the develop branch, then commit your changes. Then try to build, ig that should fix the problem. If your changes are working as expected then do force push on the branch

Would that fix the issue though? Because I have this on my local copy's develop branch too and it is completely even with the current develop branch.

[CodeChamp-SS]

@CodeChamp-SS in the most recent pull of the latest code, my Gradle build is getting stopped and failing showing this error:-
Gradle sync failed: Gradle build daemon disappeared unexpectedly
This is not happening in other android projects on my system.

do one thing revert all the commits from your branch, then pull the develop branch, then commit your changes. Then try to build, ig that should fix the problem. If your changes are working as expected then do force push on the branch

Would that fix the issue though? Because I have this on my local copy's develop branch too and it is completely even with the current develop branch.

hmm then ig you can try cleaning and then rebuilding the project, if the problem still exists i think you'll have to delete the project and then clone it again in your machine, this the only solution i could think of 😅 as i've never faced such an issue

[CodeChamp-SS]

you may also try asking on zulip may be some1else could be able to help you :-)