refactor: remove is_done from get /tasks api response (#909)

app/api/models/mentorship_relation.py

@@ -86,7 +86,6 @@ def add_models_to_namespace(api_namespace):
     },
 )
 
-
 user_dashboard_user_details = Model(
     "User details for dashboard",
     {

app/api/models/task.py

@@ -22,9 +22,6 @@ def add_models_to_namespace(api_namespace):
         "description": fields.String(
             required=True, description="Mentorship relation task description"
         ),
-        "is_done": fields.Boolean(
-            required=True, description="Mentorship relation task is done indication"
-        ),
         "created_at": fields.Float(
             required=True, description="Task creation date in UNIX timestamp format"
         ),

tests/user_journey/test_happy_path_1.py

@@ -163,11 +163,9 @@ def test_happy_path_1(self):
         new_task = tasks[0]
         task_id = new_task["id"]
         task_description = new_task["description"]
-        task_state = new_task["is_done"]
         task_completed_at = new_task["completed_at"]
 
         self.assertIsNotNone(task_id)
-        self.assertFalse(task_state)
         self.assertIsNone(task_completed_at)
         self.assertEqual(self.test_description, task_description)
 
@@ -191,11 +189,9 @@ def test_happy_path_1(self):
         updated_task = tasks[0]
         updated_task_id = updated_task["id"]
         updated_task_description = updated_task["description"]
-        updated_task_state = updated_task["is_done"]
         updated_task_completed_at = updated_task["completed_at"]
 
         self.assertEqual(task_id, updated_task_id)
-        self.assertTrue(updated_task_state)
         self.assertIsNotNone(updated_task_completed_at)
         self.assertEqual(self.test_description, updated_task_description)
 

tests/users/test_dao_dashboard.py

@@ -1,5 +1,6 @@
 import unittest
-
+from flask_restx import marshal
+from app.api.models.mentorship_relation import list_tasks_response_body
 from app.api.email_utils import generate_confirmation_token
 from app.api.dao.user import UserDAO, DashboardRelationResponseModel
 from datetime import timedelta, datetime
@@ -164,8 +165,12 @@ def test_dao_get_user_dashboard(self):
                     "pending": [],
                 },
             },
-            "tasks_todo": [self.tasks_list_1.find_task_by_id(1)],
-            "tasks_done": [self.tasks_list_1.find_task_by_id(2)],
+            "tasks_todo": [
+                marshal(self.tasks_list_1.find_task_by_id(1), list_tasks_response_body)
+            ],
+            "tasks_done": [
+                marshal(self.tasks_list_1.find_task_by_id(2), list_tasks_response_body)
+            ],
         }
         actual_response = UserDAO.get_user_dashboard(self.first_user.id)
         self.assertEqual(actual_response, expected_response)