Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated task_comment information to include if comment owned by user #1152

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mariejp
Copy link

@mariejp mariejp commented Apr 23, 2022

Description

Getting a task_comment model now returns an object with these fields:
{
"id": self.id,
"sent_by_me": sent_by_me,
"user": {
"id": self.user_id,
"name": self.user_name,
},
"user_id": self.user_id,
"task_id": self.task_id,
"relation_id": self.relation_id,
"creation_date": self.creation_date,
"modification_date": self.modification_date,
"comment": self.comment,
}

Fixes # [685]

Type of Change:

  • Code
  • Enhancement

How Has This Been Tested?

I ran the unit tests again, making sure to run python -m unittest discover tests with my updated code.

Checklist:

  • My PR follows the style guidelines of this project

  • I have performed a self-review of my own code or materials

  • Any dependent changes have been merged

  • My changes generate no new warnings

  • New and existing unit tests pass locally with my changes

@mariejp mariejp requested a review from isabelcosta as a code owner April 23, 2022 02:57
@welcome
Copy link

welcome bot commented Apr 23, 2022

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant