Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Issue #596 of updating user with current username #1159

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hirshrm
Copy link

@hirshrm hirshrm commented Dec 5, 2022

Description

Fixed Issue #596 such that when a user attempts to update their username with their current username (ex. user "123" tries to update the username to "123"), they receive an HTTP OK response and not an error. No fields will be updated and the message attached to the OK response reports that accordingly.

A test has been added to the test file to cover this edge case.

Fixes #596

Type of Change:

  • Code
  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New test method that creates a user and tries to update the username to the existing username. It asserts that the response code and message are as expected. The test passed on local device.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@hirshrm hirshrm requested a review from isabelcosta as a code owner December 5, 2022 20:17
@welcome
Copy link

welcome bot commented Dec 5, 2022

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the user with existing name and username.
1 participant