All conventions are followed in resources files #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continue of #905 |
isabelcosta
reviewed
Dec 28, 2020
| class ListAdmins(Resource): | ||
| @classmethod | ||
| @jwt_required | ||
|
|
There was a problem hiding this comment.
this empty line isn't needed right?
|
@gitpurva there are some merge conflicts, please resolve them |
|
HI, @gitpurva do you want to finish this PR or it should be closed? |
devkapilbansal
added
the
Status: Changes Requested
|
Closing due to inactivity. @gitpurva feel free to ping again if you want to continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mentioned changes in the resources file to follow same convention.
Fixes #898