Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(player): Use compose for the base player #1406

Closed
wants to merge 15 commits into from
Closed

refactor(player): Use compose for the base player #1406

wants to merge 15 commits into from

Conversation

quickdesh
Copy link
Contributor

Changes

  • Created new classes to store combined data
  • Shifted multiple components to view model's state
  • Refactored the entire player to rely on compose rather than xml
  • Rewrote the delay system for animations

@abdallahmehiz
Copy link
Member

Yooooooo

@hollowshiroyuki
Copy link

nuh uh

@quickdesh
Copy link
Contributor Author

Shifted to #1612

@quickdesh quickdesh closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quickdesh @abdallahmehiz @hollowshiroyuki @Samfun75