Skip to content

Display if block/lambda instead of __ placeholder #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Display if block/lambda instead of __ placeholder #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/helpers/clockwork_web/home_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,21 @@ def friendly_time_part(time_part)
"**"
end
end

def friendly_extract_source_from_callable(callable, with_affixes: true)
Copy link
Contributor Author

@chaadow chaadow Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's the same helper from #10 )

Copy link

@mkulsoom02 mkulsoom02 Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello

source = RubyVM::AbstractSyntaxTree.of(callable, keep_script_lines: true).source
return '-' unless source

source.strip!
return source if with_affixes

source.tap do |source|
source.delete_prefix!('{')
source.delete_suffix!('}')

source.delete_prefix!('do')
source.delete_suffix!('end')
end
end
end
end
6 changes: 3 additions & 3 deletions app/views/clockwork_web/home/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<table>
<thead>
<tr>
<th>Job</th>
<th class="width-15">Job</th>
<th class="width-15">Period</th>
<th class="width-15">Last Run</th>
<th class="width-15">Action</th>
Expand All @@ -94,8 +94,8 @@
<% if at %>
at <%= friendly_time_part(at.instance_variable_get(:@hour)) %>:<%= friendly_time_part(at.instance_variable_get(:@min)) %>
<% end %>
<% if event.instance_variable_get(:@if) %>
if __
<% if if_lambda = event.instance_variable_get(:@if) %>
if: -> <%= friendly_extract_source_from_callable(if_lambda)%>
<% end %>
</td>
<td><%= last_run(@last_runs[event.job]) %></td>
Expand Down