build(deps): update underlying ktlint to 0.47.x

[mikehardy]

Pull Request template

Purpose / Description

ktlint-gradle supports new ktlint underlying versions now

It still transitively pulls in a ktlint version with a memory leak though (0.43.2) I checked - so we still need the override

ktlint underlying is at 0.48.2: https://github.com/pinterest/ktlint/releases

But ktlint-gradle does not quite handle that yet: JLLeitschuh/ktlint-gradle#622

It goes without saying that this is not a high priority, but it is also just a big spacing diff for the most part so, 🤷

The only part of the diff which is an actual change is the build.gradle version change here: 5f7ceda#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
(transitively because of this: https://pinterest.github.io/ktlint/faq/#why-is-editorconfig-property-disabled_rules-deprecated-and-how-do-i-resolve-this)

So this updates us to 0.47.1 which is much more modern ktlint, but not the latest to avoid the upstream issue 622, and it does a format on the codebase to pull it up to standards

[mikehardy]

upstream still blocked

[github-actions]

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[mikehardy]

Fascinating! ktlint complained that java.util.CancellationException was an unused import, because there was an import of java.util.* immediately above it, but then we get this:

> Task :AnkiDroid:compilePlayDebugKotlin FAILED
e: /Users/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/servicelayer/SchedulerService.kt: (236, 26): Unresolved reference: CancellationException
e: /Users/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/servicelayer/SchedulerService.kt: (237, 24): Overload resolution ambiguity: 
public open fun i(message: String?, vararg args: Any?): Unit defined in timber.log.Timber.Forest
public open fun i(t: Throwable?, message: String?, vararg args: Any?): Unit defined in timber.log.Timber.Forest

So something in here is subtle and needs a little untangle.

This is not a high priority, just putting it here for future effort as available