fix: Show red text if the tag already exists and disable the button#20368
Merged
david-allison merged 1 commit intoankidroid:mainfrom Mar 13, 2026
Merged
fix: Show red text if the tag already exists and disable the button#20368david-allison merged 1 commit intoankidroid:mainfrom
david-allison merged 1 commit intoankidroid:mainfrom
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
Contributor
|
Important Maintainers: This PR contains Strings changes
|
criticalAY
requested changes
Feb 27, 2026
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt
Outdated
Show resolved
Hide resolved
| inputET.filters = arrayOf(addTagFilter) | ||
|
|
||
| if (!prefixTag.isNullOrEmpty()) { | ||
| // utilize the addTagFilter to append '::' properly by appending a space to prefixTag |
Contributor
There was a problem hiding this comment.
Why removing the comment?
Contributor
Author
There was a problem hiding this comment.
Sorry, that wasn’t intentional. I’ll add it back.
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt
Outdated
Show resolved
Hide resolved
criticalAY
added
Needs Author Reply
criticalAY
requested changes
Feb 27, 2026
criticalAY
requested changes
Mar 2, 2026
Contributor
criticalAY
left a comment
criticalAY
left a comment
There was a problem hiding this comment.
Changes are not reverted
david-allison
added
Needs Review
Needs Second Approval
david-allison
approved these changes
Mar 9, 2026
david-allison
added
the
Needs Author Reply
david-allison
approved these changes
Mar 10, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
If you re-request review, it removes my approval. Still good to go
Contributor
Author
|
Got it!, Thanks |
criticalAY
removed
the
Needs Author Reply
criticalAY
approved these changes
Mar 11, 2026
Contributor
criticalAY
left a comment
criticalAY
left a comment
There was a problem hiding this comment.
I am ok with the code, the commit can be squashed.
Thankyou!
criticalAY
added
Pending Merge
david-allison
force-pushed
the
add-tag-validation
branch
from
dab5259 to
26a9aa5
Compare
david-allison
removed
the
squash-merge
Contributor
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The PR fixes the issue where adding an already existing tag does not provide proper validation feedback.
Now the Add Tag dialog shows a red error message and disables the OK button when a duplicate tag is entered.
Fixes
Approach
Added validation in
TagsDialog.ktto check whether the entered tag already exists.TagsUtil.getUniformedTag()How Has This Been Tested?
Ran the app and verified that when entering an existing tag in the Add Tag dialog, a red error message is displayed and the OK button remains disabled.
Also verified that entering a new unique tag enables the OK button and allows the tag to be added successfully.
before:
after:
Learning (optional, can help others)
None
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist