Skip to content

fix: potential storage leak in AudioRecorder#20404

Open
criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY:fix/recorder-memory-leak
Open

fix: potential storage leak in AudioRecorder#20404
criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY:fix/recorder-memory-leak

Conversation

@criticalAY
Copy link
Contributor

Purpose / Description

Here I want to addresses concerns regarding the lifecycle and cleanup of temporary recording files. Previously, files created in the cacheDir could persist indefinitely.

Fixes

Approach

NA

How Has This Been Tested?

Added Unit tests

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Feel free to squash, better to keep the test and implementation in the same commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential storage leak in audio recording createTempFile

2 participants