Skip to content

fix: prevent deck overlap by skipping redundant scroll for visible items #20406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-allison merged 1 commit into from
Mar 9, 2026
+12 −0
Merged

fix: prevent deck overlap by skipping redundant scroll for visible items #20406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ import com.ichi2.anki.utils.ShortcutUtils
import com.ichi2.anki.utils.ext.dismissAllDialogFragments
import com.ichi2.anki.utils.ext.getSizeOfBitmapFromCollection
import com.ichi2.anki.utils.ext.launchCollectionInLifecycleScope
import com.ichi2.anki.utils.ext.positionIsVisible
import com.ichi2.anki.utils.ext.setFragmentResultListener
import com.ichi2.anki.utils.ext.showDialogFragment
import com.ichi2.anki.utils.runWithOOMCheck
Expand Down Expand Up @@ -784,6 +785,12 @@ open class DeckPicker :

fun onFocusedDeckChanged(deckId: DeckId?) {
val position = deckId?.let { viewModel.findDeckPosition(it) } ?: 0

// Skip centering if the deck is already on screen.
// Scrolling during a tap animation causes deck labels to overlap on older devices.
if (decksLayoutManager.positionIsVisible(position)) {
return
}
// HACK: a small delay is required before scrolling works
deckPickerBinding.decks.postDelayed({
decksLayoutManager.scrollToPositionWithOffset(position, deckPickerBinding.decks.height / 2)
Expand Down
5 changes: 5 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/utils/ext/LinearLayoutManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,8 @@ val LinearLayoutManager.visibleItemPositions: IntRange
}
return first..last
}

/**
* Returns true if the position is currently visible.
*/
fun LinearLayoutManager.positionIsVisible(position: Int): Boolean = position in visibleItemPositions
Loading