Added a unit test for checking cloze counter numbering while toggling.#20408
Open
Alok-Silswal wants to merge 1 commit intoankidroid:mainfrom
Open
Added a unit test for checking cloze counter numbering while toggling.#20408Alok-Silswal wants to merge 1 commit intoankidroid:mainfrom
Alok-Silswal wants to merge 1 commit intoankidroid:mainfrom
Conversation
Author
|
@david-allison Submitting this as a separate PR to keep the original fix focused and instructions as given in #20398 (comment) i.e.
This change only adds additional test coverage for toggle behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
While solving #20350 issue and working with #20398 PR, I noticed that there is no unit test that checks if the cloze counter number is correct while toggling mode (from
INCREMENTtoNO_INCREMENTand vice-versa).It is the by-product of observations as mentioned in #20350 (comment)
As a result of the absence of this unit test, even an incorrect implementation(intermediate code I used while testing) is passing all the unit tests.
Fixes
Approach
It checks if the cloze counter number is assigned the correct value when we switch modes each time, by creating a unit test.
How Has This Been Tested?
This test fails on
mainbut passes with fix made in #20398 PR.Checklist