fix: minor Android Studio warnings#20412
Draft
aadityarshah wants to merge 1 commit intoankidroid:mainfrom
Draft
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
This commit fixes some basic warnings or problems in the codebase.
ea74373 to
325cb50
Compare
|
@aadityarshah It is not a review. But you do not have to omit items that are not ticked in the checklist. Also, have you noticed that it has failed Unit Tests? |
Author
|
@Alok-Silswal Thank you for notifying me about the fact that we do not have to omit items that are not ticked in the checklist. |
|
If this PR is not complete, then you may mark this as a draft for the meantime. |
Author
|
@Alok-Silswal okay thank you for your advice, I will convert to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
As a new contributor, I wanted to get familiar with the codebase and wanted to have my first pull request merged. Fixes #13282 seemed to be a good starting point and hence, I decided to fix some Android Studio warnings.
Fixes
AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt)Approach
Ran
Code/Inspect Codein Android Studio and reviewed the warnings/problems in the code and made the following changes:CardBrowserTest.ktin the directoryAnkiDroid/src/test/java/com/ichi2/anki, added a space between 'current' and 'use' since it was a problem in the fileAnalyticalWidgetProviderTest.ktin the directoryAnkiDroid/src/test/java/com/ichi2/anki/widgetandUtils.ktin the directoryAnkiDroid/src/main/java/com/ichi2/anki/dialogs, added thepackage com.ichi2.anki ...line to resolve the warning "Package directive does not match the file location"Test21And26.ktin the directoryAnkiDroid/src/test/java/com/ichi2/compat, removed the redundantinnercall on the classPermissionDenied.How Has This Been Tested?
./gradlew assembleDebugwas ran using OpenJDK 24 version on Windows 11 and since it executed successfully, it was concluded that the changes have worked successfully.:AnkiDroidmodule to an emulator which ran successfullyChecklist
Please, go through these checks before submitting the PR.