Skip to content

fix: remove app from recents if in an invalid state #20415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 2 commits into from
Mar 12, 2026
Merged

fix: remove app from recents if in an invalid state #20415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d35e907
fix: remove app from recents if in an invalid state
david-allison Mar 7, 2026
c7dfd33
docs: add logging TODO if Application is uninitialized
david-allison Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/workarounds/AppLoadedFromBackupWorkaround.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ object AppLoadedFromBackupWorkaround {
if (AnkiDroidApp.isInitialized) {
return false
}
// TODO: Timber likely does not work on this path - maybe add a check in IntentHandler

// #7630: Can be triggered with `adb shell bmgr restore com.ichi2.anki` after AnkiDroid settings are changed.
// Application.onCreate() is not called if:
Expand All @@ -73,7 +74,10 @@ object AppLoadedFromBackupWorkaround {
Themes.setTheme(this)
// Avoids a SuperNotCalledException
activitySuperOnCreate(savedInstanceState)
finish()
// Process.killProcess is a hard kill. I suspect that some Android OSes leave has the app in
// an invalid state after this occurs (meaning Application.onCreate is not called).
// Before killProcess, gracefully kill the app, removing it from the recents list
finishAndRemoveTask()

// If we don't kill the process, the backup is not "done" and reopening the app show the same message.
Thread {
Expand Down
Loading