Skip to content

Bug fix - Gesture navigation overriding Slider #20419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 1 commit into from
Mar 14, 2026
+17 −1
Merged

Bug fix - Gesture navigation overriding Slider #20419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@ package com.ichi2.anki.previewer

import android.content.Context
import android.content.Intent
import android.graphics.Rect
import android.os.Bundle
import android.view.KeyEvent
import android.view.Menu
import android.view.MenuItem
import android.view.View
import androidx.appcompat.widget.Toolbar
import androidx.core.os.bundleOf
import androidx.core.view.ViewCompat
import androidx.core.view.doOnLayout
import androidx.core.view.isVisible
import androidx.fragment.app.viewModels
import androidx.lifecycle.flowWithLifecycle
Expand Down Expand Up @@ -133,9 +136,15 @@ class PreviewerFragment :

binding.slider.apply {
valueTo = cardsCount.toFloat()
doOnLayout {
Copy link
Contributor Author

@lonewolf2208 lonewolf2208 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the gesture exclusion area once the slider has its final size

Copy link
Member

@david-allison david-allison Mar 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer code comments, rather than GitHub comments

If it's useful for reviewers, it'll be useful for future maintainers in the codebase

updateSliderGestureExclusion(this)
}
addOnLayoutChangeListener { _, _, _, _, _, _, _, _, _ ->
Copy link
Contributor Author

@lonewolf2208 lonewolf2208 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the exclusion area again if the slider layout changes later

updateSliderGestureExclusion(this)
}
addOnSliderTouchListener(
object : Slider.OnSliderTouchListener {
override fun onStartTrackingTouch(slider: Slider) {}
override fun onStartTrackingTouch(slider: Slider) = Unit

override fun onStopTrackingTouch(slider: Slider) {
viewModel.onSliderChange(slider.value.toInt())
Expand Down Expand Up @@ -184,6 +193,13 @@ class PreviewerFragment :
bindingMap = BindingMap(sharedPrefs(), PreviewerAction.entries, this)
}

private fun updateSliderGestureExclusion(slider: Slider) {
ViewCompat.setSystemGestureExclusionRects(
slider,
listOf(Rect(0, 0, slider.width, slider.height)),
)
}

private fun setupFlagMenu(menu: Menu) {
val submenu = menu.findItem(R.id.action_flag).subMenu
lifecycleScope.launch {
Expand Down
Loading