Test getFileCachedCopy returns absolute path

[manocormen]

Purpose / Description

Regression test that ensures that getFileCachedCopy in ImportUtils.kt returns a regular absolute path, as per the @NeedsTest.

Fixes

Relates to #13283.

Approach

I looked at the older getFileCachedCopy. It used to return a URI-encoded path. It was updated to return a regular absolute filepath. That's when @NeedsTest was added.

To discriminate between old/new behavior, I used a filename with a space, since they have a particular URI-encoding. If getFileCachedCopy were to return a URI-encoded path again, the test would catch the regression.

I used the already-implemented TestFileImporter to handle method dependencies and isolate the behavior under test.

How Has This Been Tested?

./gradlew jacocoUnitTestReport
./gradlew lintRelease
./gradlew ktlintCheck
./gradlew assembleDebug

Learning

A couple of things I did that helped:

• Contrasting the old/new method helped clarify the motivation behind the @NeedsTest.
• Checking for helpers (TestFileImporter) helped save time and keep the commit short.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas NA
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens NA
• UI Changes: You have tested your change using the Google Accessibility Scanner NA

[welcome]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[david-allison]

Looks great!