Skip to content

Fixes the flaky UncompletedCoroutinesError in AnkiDroidJsAPITest specifically on Windows CI runners. #20442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mahakbajpai wants to merge 1 commit into from
+4 −1
Closed

Fixes the flaky UncompletedCoroutinesError in AnkiDroidJsAPITest specifically on Windows CI runners. #20442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion AnkiDroid/src/test/java/com/ichi2/anki/AnkiDroidJsAPITest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.ichi2.anki.common.time.TimeManager
import com.ichi2.anki.libanki.CardType
import com.ichi2.anki.libanki.testutils.ext.BASIC_NOTE_TYPE_NAME
import com.ichi2.anki.libanki.testutils.ext.setFlag
import kotlinx.coroutines.test.runTest
import net.ankiweb.rsdroid.withoutUnicodeIsolation
import org.hamcrest.CoreMatchers.equalTo
import org.hamcrest.MatcherAssert.assertThat
Expand All @@ -33,6 +34,8 @@ import org.junit.Ignore
import org.junit.Test
import org.junit.runner.RunWith
import kotlin.test.assertEquals
import kotlin.time.Duration.Companion.milliseconds
import kotlin.time.Duration.Companion.minutes

@RunWith(AndroidJUnit4::class)
class AnkiDroidJsAPITest : RobolectricTest() {
Expand Down Expand Up @@ -416,7 +419,7 @@ class AnkiDroidJsAPITest : RobolectricTest() {

@Test
fun ankiGetNoteTagsTest() =
runTest {
runTest(timeout = 120000.milliseconds) {
val n =
addBasicNote("Front", "Back").update {
tags = mutableListOf("tag1", "tag2", "tag3")
Expand Down
Loading