fix(card-browser): search issues

[david-allison]

Purpose / Description

Massive thanks to Zorn here.

Two issues:

1. I messed up and kept a searchTerms variable around
2. There is an incompatibility with MenuProvider and the Material 2 androidx.appcompat.widget.SearchView

• State is no longer restored when using MenuProvider, causing keyboard flickers to occur.

Fixes

• Fixes [2.24.0alpha8] Card browser context menu is broken #20440

Approach

1. Replace searchTerms with a derived value from the new SearchRequest class
2. Work around this issue, in 1 case by modifying the menu directly, to stop a flicker, in the other, manually close the keyboard after a search

How Has This Been Tested?

API 33 phone emulator

• Used the Card browser shortcut
• Typed text into the search bar - no more keyboard flicker

Learning (optional, can help others)

I will be SO glad when we get rid of the old SearchView, it's the cause of so much bad code

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner