Skip to content

refactor(card-browser): SearchFilters#20450

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:searchFilters
Mar 14, 2026
Merged

refactor(card-browser): SearchFilters#20450
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:searchFilters

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Mar 13, 2026

Split out from my big PR for

This removes a class, and blocks a developer from forgetting to handle all cases when adding a new filter.

How Has This Been Tested?

Trusting CI

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Mar 13, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Mar 14, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 14, 2026
Merged via the queue into ankidroid:main with commit 4190e28 Mar 14, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Mar 14, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 14, 2026
@david-allison david-allison deleted the searchFilters branch March 14, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants