Skip to content

fix(deck-options): crash on API 30 and below#20457

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:fix-deck-options
Mar 14, 2026
Merged

fix(deck-options): crash on API 30 and below#20457
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:fix-deck-options

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Mar 13, 2026

Purpose / Description

TypedArray crashes when cast to AutoCloseable on API 30 or below

Fixes

Approach

Replace .use with usingStyledAttributes

How Has This Been Tested?

No longer crashes on an API 29 emulator

Learning (optional, can help others)

Introduced by f157e17

TypedArray crashes when cast to AutoCloseable on API 30 or below

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added this to the 2.24 release milestone Mar 13, 2026
@david-allison david-allison added Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Mar 13, 2026
@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 14, 2026
Introduced by f157e17

TypedArray crashes when cast to AutoCloseable on API 30 or below

Fixes 20456
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Mar 14, 2026
@david-allison david-allison requested a review from BrayanDSO March 14, 2026 12:42
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 14, 2026
@lukstbit lukstbit enabled auto-merge March 14, 2026 17:38
@lukstbit lukstbit added this pull request to the merge queue Mar 14, 2026
Merged via the queue into ankidroid:main with commit 30af195 Mar 14, 2026
15 checks passed
@github-actions github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Mar 14, 2026
@david-allison david-allison deleted the fix-deck-options branch March 14, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.24.0alpha8] FilteredDeckOptions crashes on open

3 participants