fix: handle nonfatal review reminder deserialization errors on startup#20462
Closed
naurakrbna wants to merge 1 commit intoankidroid:mainfrom
Closed
fix: handle nonfatal review reminder deserialization errors on startup#20462naurakrbna wants to merge 1 commit intoankidroid:mainfrom
naurakrbna wants to merge 1 commit intoankidroid:mainfrom
Conversation
When review reminder data stored in SharedPreferences cannot be deserialized (e.g. due to a schema mismatch), catch the exception and notify the user via a toast instead of crashing the app. Closes ankidroid#20168 Fixes ankidroid#20163 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: handle nonfatal review reminder deserialization errors on startup. At present, corrupt review reminder data in SharedPreferences can't be deserialized, the app crashes on startup. This catches the exception in
scheduleAllEnabledReviewReminderNotificationsand shows a toast instead, so the app can continue starting up normally.Changes:
AlarmManagerService.kt: catchSerializationExceptionandIllegalArgumentExceptionwhen reading fromReviewRemindersDatabase,show toast on failure
03-dialogs.xml: addboot_service_review_reminders_corruptstringAlarmManagerServiceTest.kt: test that corrupt data doesn't crash andshows toast