Skip to content

Improve the "Reposition new cards" dialog#20470

Closed
dagangtj wants to merge 1 commit intoankidroid:mainfrom
dagangtj:improve-reposition-dialog
Closed

Improve the "Reposition new cards" dialog#20470
dagangtj wants to merge 1 commit intoankidroid:mainfrom
dagangtj:improve-reposition-dialog

Conversation

@dagangtj
Copy link

Fixes #20465

Changes

  • ✅ Add maxLength="10" to both input fields to limit number size
  • ✅ Disable OK button when either field is empty (using TextWatcher)
  • ✅ Replace "OK" button text with "Reposition" for clarity

Implementation Details

  • Added TextWatcher to both input fields to monitor changes
  • Button state updates dynamically when text changes
  • Initial button state is checked when dialog is shown
  • Added new string resource reposition in 03-dialogs.xml

Testing

  • Empty fields disable the button
  • Filling both fields enables the button
  • Button text shows "Reposition" instead of "OK"
  • Input is limited to 10 digits

- Add maxLength="10" to both input fields to limit number size
- Disable OK button when either field is empty
- Replace "OK" button text with "Reposition" for clarity
- Add TextWatcher to monitor input changes and update button state

Fixes ankidroid#20465
@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Mar 15, 2026
@david-allison
Copy link
Member

This looks AI generated, there's no justification for the numbers selected and the PR template wasn't followed.

Closing as-per https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md#new-contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Needs Review New contributor Strings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the "Reposition new cards" dialog

2 participants