Skip to content

Remove redundant constructs in Kotlin files #20474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukstbit merged 1 commit into from
Mar 15, 2026
+5 −6
Merged

Remove redundant constructs in Kotlin files #20474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/InitialActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ internal fun selectAnkiDroidFolder(
return if (canManageExternalStorage) {
AnkiDroidFolder.PublicFolder(PermissionSet.EXTERNAL_MANAGER)
} else {
return AnkiDroidFolder.AppPrivateFolder
AnkiDroidFolder.AppPrivateFolder
}
}

Expand Down
7 changes: 3 additions & 4 deletions AnkiDroid/src/main/java/com/ichi2/anki/deckpicker/DisplayDeckNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,9 @@ fun DeckNode.addVisibleToList(list: MutableList<DeckNode>) {
}

@SuppressLint("LocaleRootUsage")
private fun DeckNode.nameMatchesFilter(filter: CharSequence?): Boolean {
return if (filter == null) {
private fun DeckNode.nameMatchesFilter(filter: CharSequence?): Boolean =
if (filter == null) {
true
} else {
return node.name.lowercase(Locale.getDefault()).contains(filter) || node.name.lowercase(Locale.ROOT).contains(filter)
node.name.lowercase(Locale.getDefault()).contains(filter) || node.name.lowercase(Locale.ROOT).contains(filter)
}
}
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SavedBrowserSearchesDialogFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ fun CardBrowser.registerSavedSearchActionHandler(action: (Int, String?) -> Unit)
this,
) { _, bundle ->
val type = bundle.getInt(SavedBrowserSearchesDialogFragment.ARG_TYPE)
val searchName = bundle.getString(SavedBrowserSearchesDialogFragment.ARG_SAVED_SEARCH)
val searchName = bundle.getString(ARG_SAVED_SEARCH)
Timber.d("On user saved search selection named: %s", searchName)
action(type, searchName)
}
Expand Down
Loading