fix(widget): standardize alarm interval to 10 minutes and document updatePeriodMillis limitation#20482
Merged
david-allison merged 1 commit intoankidroid:mainfrom Mar 15, 2026
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
MandeepT19
changed the title
MandeepT19
force-pushed
the
fix/widget-alarm-interval
branch
from
193be65 to
05c77ea
Compare
MandeepT19
changed the title
Comment on lines
+104
to
+105
| SystemClock.elapsedRealtime() + 10.minutes.inWholeMilliseconds, | ||
| 10.minutes.inWholeMilliseconds, |
Member
There was a problem hiding this comment.
Isn't 1 minute a better duration?
Contributor
Author
There was a problem hiding this comment.
the real reason for suggesting this approach is that by using 1 minute there are few drawbacks like: as we are firing it every minute then it will drain the battery more faster and it was also mentioned for the 10 mins in the TODO and the code was mismatching and reason behind choosing 10 mins was because it is neutral for it
Contributor
Author
There was a problem hiding this comment.
Understood, reverting it back in a minute
david-allison
added
the
Needs Author Reply
MandeepT19
force-pushed
the
fix/widget-alarm-interval
branch
from
41c86cf to
3e0c59d
Compare
Comment on lines
+11
to
+13
| <!-- Note: It was suggested to use updatePeriodMillis but it has a minimum of 30 mins enforced by the android | ||
| which is too infrequent for due card count as it can create difficulty for the user, | ||
| and used a 10 minutes alarm as it was intended.--> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- Note: It was suggested to use updatePeriodMillis but it has a minimum of 30 mins enforced by the android | |
| which is too infrequent for due card count as it can create difficulty for the user, | |
| and used a 10 minutes alarm as it was intended.--> |
Comment on lines
+9
to
+11
| <!-- Note: It was suggested to use updatePeriodMillis but it has a minimum of 30 mins enforced by the android | ||
| which is too infrequent for due card count as it can create difficulty for the user, | ||
| and used a 10 minutes alarm as it was intended--> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- Note: It was suggested to use updatePeriodMillis but it has a minimum of 30 mins enforced by the android | |
| which is too infrequent for due card count as it can create difficulty for the user, | |
| and used a 10 minutes alarm as it was intended--> |
Member
|
If the TODOs aren't actionable, just remove them |
Contributor
Author
Understood, removing the TODOs entirely |
…r XML files `updatePeriodMillis` has a minimum of 30 mins Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
david-allison
force-pushed
the
fix/widget-alarm-interval
branch
from
a01ea9b to
f559049
Compare
david-allison
added
Pending Merge
david-allison
approved these changes
Mar 15, 2026
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description:
There was a difference between a comment and the real code and also proposed a new approach
Fixes
There is no issue number since this was TODO and it is located inside the widget_provider_deck_picker.xml at line 11
Approach
So it was mentioned to use updatePeriodMillis and by research i found out it's minimum time is for 30 mins and that time is slower/delayed when the widget is added because it can create inconsistency and confusion for the user and the code was not following the 10 mins thing mentioned in the TODO so updated it to 10 minutes instead of being set at 1 minute.
How Has This Been Tested?
The tests were performed on the emulator device and it was running successfully without any error or crash
##Learning (optional, can help others)
Referred topic for this problem was updatePeriodMillis, source for learning were developer.android.com
Checklist